8000 Change description of _compute_lower_bound method · Issue #18765 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Change description of _compute_lower_bound method #18765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ashkush opened this issue Nov 5, 2020 · 5 comments
Closed

Change description of _compute_lower_bound method #18765

ashkush opened this issue Nov 5, 2020 · 5 comments
Labels
Documentation

Comments

@ashkush
Copy link
Contributor
ashkush commented Nov 5, 2020

In sklearn.mixture._bayeisan_mixture._compute_lower_bound

Description needs to be changed

""Estimate the lower bound of the model.

    The lower bound on the likelihood (of the training data with respect to
    the model) is used to detect the convergence and has to **decrease** at
    each iteration."""

to
""Estimate the lower bound of the model.

    The lower bound on the likelihood (of the training data with respect to
    the model) is used to detect the convergence and has to **increase** at
    each iteration."""
@NicolasHug
Copy link
Member
NicolasHug commented Nov 5, 2020 •
edited
Loading

thanks @Ashu9808, for such small suggestions feel free to directly open a PR instead of opening an issue.

@Ankit810
Copy link
Contributor
Ankit810 commented Nov 6, 2020

Hi!
Can I work on this? @NicolasHug

@NicolasHug
Copy link
Member

Thanks @Ankit810 , let's leave the opportunity open for @Ashu9808 to submit a PR in the following days. Otherwise yes feel free to take over (~next week?)

@Ankit810
Copy link
Contributor
Ankit810 commented Nov 6, 2020

Absolutely fine with it @NicolasHug
I'll take it on the 13th if there's no progress

@NicolasHug
Copy link
Member

Closed by #18766

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NicolasHug @ashkush @Ankit810
0