8000 neighbors' `fit_predict` is NOT available to novelty detection · Issue #18739 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

neighbors' fit_predict is NOT available to novelty detection #18739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yiyange opened this issue Nov 3, 2020 · 2 comments · Fixed by #18754
Closed

neighbors' fit_predict is NOT available to novelty detection #18739

yiyange opened this issue Nov 3, 2020 · 2 comments · Fixed by #18754
Labels
Documentation

Comments

@yiyange
Copy link
yiyange commented Nov 3, 2020

Describe the issue linked to the documentation

This line is wrong

scikit-learn/sklearn/neighbors/_lof.py

Line 196 in 4d7e611

**Only available for novelty detection (when novelty is set to True).**

inconsistent with documentation in other places as well as the logic downstream:

scikit-learn/sklearn/neighbors/_lof.py

Lines 218 to 221 in 4d7e611

if self.novelty:
msg = ('fit_predict is not available when novelty=True. Use '
'novelty=False if you want to predict on the training set.')
raise AttributeError(msg)

Suggest a potential alternative/fix

**Only available for outlier detection (when novelty is set to False).**
@yiyange yiyange changed the title neighbors' fIt_predict is NOT available to novelty detection neighbors' fit_predict is NOT available to novelty detection Nov 3, 2020
@NicolasHug
Copy link
Member

Thanks @yiyange , would you liek to submit a PR to fix the doc?

@yiyange yiyange mentioned this issue Nov 3, 2020
Merged
@yiyange
Copy link
Author
yiyange commented Nov 3, 2020

@NicolasHug I have a PR out ^^, but failing on Publish Test Results.

##[error]TF400898: An Internal Error Occurred.

Looking for advice on how to fix the test. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOC Fix doc of fit_predict in neighbors/_lof.py yiyange/scikit-learn
2 participants
@NicolasHug @yiyange
0