10000 Why the raise ValueError happen when (y_true < 0) or (y_pred < 0) with log1p? · Issue #18477 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Why the raise ValueError happen when (y_true < 0) or (y_pred < 0) with log1p? #18477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
m-zakeri opened this issue Sep 28, 2020 · 1 comment
Closed

Why the raise ValueError happen when (y_true < 0) or (y_pred < 0) with log1p? #18477

m-zakeri opened this issue Sep 28, 2020 · 1 comment

Comments

@m-zakeri
Copy link
m-zakeri commented Sep 28, 2020 •
edited
Loading

Why the raise ValueError happen when (y_true < 0) or (y_pred < 0), while log1p is used which can handle negative numbers greater than -1?

Originally posted by @m-zakeri in #9963 (comment)
@NicolasHug
Copy link
Member

I think the reason we use log(1 + y) instead of log(y) is because we still want to allow y to be 0. But we still don't want y < 0.

Since this is a question and since I think it's now answered, I'll close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NicolasHug @m-zakeri
0