8000 Specify minimal supported numpy and scipy version in pyproject.toml · Issue #16788 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Specify minimal supported numpy and scipy version in pyproject.toml #16788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rth opened this issue Mar 28, 2020 · 1 comment · Fixed by #16823
Closed

Specify minimal supported numpy and scipy version in pyproject.toml #16788

rth opened this issue Mar 28, 2020 · 1 comment · Fixed by #16823
Labels
Blocker Build / CI
Milestone
0.23

Comments

@rth
Copy link
Member
rth commented Mar 28, 2020 •
edited
Loading

Following the addition of pyproject.toml, we should specify minimal supported version there, so wheels are always built with the oldest supported numpy (for each supported Python version). Because we use the scipy cython BLAS API wheels should also be built with oldest supported scipy (also Python version dependent).

Specifying "numpy>=1.13.3", "scipy>=0.19.1" is not enough I think.

See how it is done in,

Should be an easy fix, but marking as a blocker for the release. Somewhat related #15917

Discovered while working on scikit-learn-contrib/scikit-learn-extra#51
@rth rth added this to the 0.23 milestone Mar 28, 2020
@BenjaminLiuPenrose BenjaminLiuPenrose mentioned this issue Apr 1, 2020
Merged
@BenjaminLiuPenrose
Copy link
Contributor

Potential fixes in #16823

@cmarmo cmarmo removed the help wanted label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Build / CI
Projects
None yet
Milestone
0.23
Development

Successfully merging a pull request may close this issue.

BLD Sets minimal supported numpy version in pyproject.toml BenjaminLiuPenrose/scikit-learn
3 participants
@rth @cmarmo @BenjaminLiuPenrose
0