8000 Consider using integer random_state in IterativeImputer · Issue #15611 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Consider using integer random_state in IterativeImputer #15611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
david-cortes opened this issue Nov 12, 2019 · 3 comments
Closed

Consider using integer random_state in IterativeImputer #15611

david-cortes opened this issue Nov 12, 2019 · 3 comments
Labels
API

Comments

@david-cortes
Copy link
Contributor
david-cortes commented Nov 12, 2019 •
edited
Loading

Lots of algorithms that rely on randomization offer an argument random_state through which it's possible to pass them RNG seeds that would ensure reproducible results. The IterativeImputer class will take some regressor/classifier and set their attribute random_state to a NumPy MT19937 object class if the object has such attribute, in such a way that this object is modified implicitly once the regressor/classifier to which it was assigned produces some random number.

This is fine for SciKit-Learn’s own classes, but other libraries which provide different regressors/classifiers which are SciKit-Learn-compatible (at least according to tests) might not be able to use such RandomState objects (e.g. if they generate random numbers in C++ with some method other than MT19937).

For example, XGBoost and LightGBM SciKit-Learn-compatible classes will only accept integers as parameters for their random_state, and there’s potentially many others too which will only accept integers.

Would be nice if IterativeImputer would instead generate a random integer seed to pass to the regressor/classifier at each iteration, so that it could be used with more external libraries.
@rth
Copy link
Member
rth commented Nov 14, 2019

+1 there is a related discussion in #14042 about dropping non integer random_state object input althogether.

Would you like to make a PR for IterativeImputer ?

@rth rth added the API label Nov 14, 2019
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Nov 15, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
4bbb6ef
@david-cortes david-cortes mentioned this issue Nov 15, 2019
Merged
@david-cortes
Copy link
Contributor Author

Created a PR for setting random_state to an integer. Not sure if it'd be more appropriate to do this, or to avoid setting any random_state at all for the estimator inside InterativeImputer, since the estimator can also be passed a random_state in their initialization arguments.

david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Nov 20, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
01b04c5
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Nov 20, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
49cdfc1
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Dec 13, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
ffeb54a
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Dec 13, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
4ee0ff2
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Dec 13, 2019
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
290d7ac
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Jan 11, 2020
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
0859f9a
@jnothman jnothman mentioned this issue Mar 5, 2020
Closed
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Jul 12, 2020
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
e800ea3
david-cortes added a commit to david-cortes/scikit-learn that referenced this issue Aug 16, 2020
@david-cortes
pass integer random_state to estimator in imputer (scikit-learn#15611)
b985fbf
@david-cortes
Copy link
Contributor Author

Fix was merged, closing the issue.

@ghost ghost mentioned this issue Nov 19, 2023
Closed
@tuscland tuscland mentioned this issue Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rth @david-cortes
0