8000 Make sure the CI fails on Deprecation and Future warnings · Issue #15381 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Make sure the CI fails on Deprecation and Future warnings #15381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrinjalali opened this issue Oct 28, 2019 · 3 comments
Closed

Make sure the CI fails on Deprecation and Future warnings #15381

adrinjalali opened this issue Oct 28, 2019 · 3 comments
Labels
Build / CI help wanted Moderate Anything that requires some knowledge of conventions and best practices

Comments

@adrinjalali
Copy link
Member

Sometimes the CI passes eventhough these warnings are raised in our tests. We should make sure they fail and the issues are caught.
@adrinjalali adrinjalali added Moderate Anything that requires some knowledge of conventions and best practices Build / CI help wanted labels Oct 28, 2019
@NicolasHug
Copy link
Member

You mean you want all the CIs to fail? I like that we just have 2 of them checking the warnings. If they're the only ones failing which happens quite often, you know the fix is simple.

@adrinjalali
Copy link
Member Author

I don't mind if not all of them fail. Ideally the all would, since some warnings may be present only under certain circumstances, but don't mind.

I opened the issue because we have seen cases where the CI simply doesn't fail even when those warnings are there, as in, none of them fails.

@cmarmo cmarmo mentioned this issue Nov 8, 2019
Closed
@cmarmo cmarmo mentioned this issue Feb 6, 2020
Closed
@lesteve
Copy link
Member
lesteve commented Jan 21, 2025

I think this is not relevant anymore since we are already checking FutureWarning and DeprecationWarning in some CI builds with SKLEARN_WARNINGS_AS_ERRORS

@lesteve lesteve closed this as completed Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI help wanted Moderate Anything that requires some knowledge of conventions and best practices
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@NicolasHug @adrinjalali @lesteve
0