8000 Stop cythonizing sdist PyPi releases · Issue #14863 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Stop cythonizing sdist PyPi releases #14863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rth opened this issue Sep 1, 2019 · 1 comment
Closed

Stop cythonizing sdist PyPi releases #14863

rth opened this issue Sep 1, 2019 · 1 comment
Labels
Build / CI
Milestone
0.22

Comments

@rth
Copy link
Member
rth commented Sep 1, 2019 •
edited
Loading

I think we should stop cythonizing our sdist releases uploaded to PyPi. Cython is not forward compatible, meaning that a sdist generated for Py3.7 will very likely fail to install on Py3.8 (this also applied to Py3.6 -> Py3.7 before). At the same time Python is mostly backward compatible, so code written for py3.6 is going to work with Py3.7 (with maybe a few warnings).

So by cythonizing sdist releases we are hurting reproducibility because it will not be possible to install current scikit-learn from sources with latest python a few years from now.

There have been a few issues related to this as far as I remember.

Instead we should add cython as a build dependency.

This will be transparent for most users, that use pre-build wheels anyway.

Numpy is also going in that direction numpy/numpy#14453 and I think we should too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
0.22
2 participants
@ogrisel @rth
0