8000 Class prior in Naive Bayes · Issue #1486 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Class prior in Naive Bayes #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Dec 23, 2012 · 4 comments
Closed

Class prior in Naive Bayes #1486

amueller opened this issue Dec 23, 2012 · 4 comments
Labels
Easy Well-defined and straightforward way to resolve Enhancement

Comments

@amueller
Copy link
Member

The class_prior in NB should be an __init__ parameter, not fit parameter imho.
I thought we had moved all parameter that don't depend on the number of samples to fit.

It just came up on the ml.

Also, if it is an __init__ parameter, maybe it should be called class_weight. Depends on whether the meaning and range of values is the same as for the linear algorithms.
@GaelVaroquaux
Copy link
Member

The class_prior in NB should be an init parameter, not fit
parameter imho. I thought we had moved all parameter that don't depend
on the number of samples to fit.

+1

@mrshu mrshu mentioned this issue Dec 30, 2012
Closed
@ogrisel
Copy link
Member
ogrisel commented Dec 30, 2012

+1 on my side too, but I would like to hear @larsmans' opinion on this.

@larsmans
Copy link
Member
larsmans commented Jan 2, 2013

+1. and if we're going to move it, we might just as well rename it to class_weight in the process.

@amueller
Copy link
Member Author
amueller commented Jan 3, 2013

Closed in #1499.

@amueller amueller closed this as completed Jan 3, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ogrisel @GaelVaroquaux @larsmans @amueller
0