8000 Add Display object for plot_partial_dependence · Issue #14596 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Add Display object for plot_partial_dependence #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Aug 8, 2019 · 1 comment · Fixed by #14646
Closed

Add Display object for plot_partial_dependence #14596

qinhanmin2014 opened this issue Aug 8, 2019 · 1 comment · Fixed by #14646
Labels
API Blocker
Milestone
0.22

Comments

@qinhanmin2014
Copy link
Member

Seems that Andy and I agree that we don't need a display object for plot_tree, opinions from other core devs are welcomed.
We'll need to return a Display object in plot_partial_dependence, I don't think this breaks current API (because currently we return nothing).
ping @thomasjpfan do you want to finish this?
@qinhanmin2014 qinhanmin2014 added this to the 0.22 milestone Aug 8, 2019
@thomasjpfan
Copy link
Member

Yup. I’ll finish this. 😆

@thomasjpfan thomasjpfan mentioned this issue Aug 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
API Blocker
Projects
None yet
Milestone
0.22
Development

Successfully merging a pull request may close this issue.

[MRG] Adds Plotting API to Partial Dependence thomasjpfan/scikit-learn
2 participants
@thomasjpfan @qinhanmin2014
0