8000 Add common test for .transform on different sparse formats · Issue #14176 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Add common test for .transform on different sparse formats #14176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rth opened this issue Jun 24, 2019 · 1 comment
Open

Add common test for .transform on different sparse formats #14176

rth opened this issue Jun 24, 2019 · 1 comment
Labels
help wanted module:test-suite everything related to our tests

Comments

@rth
Copy link
Member
rth commented Jun 24, 2019

As mentioned in #14140 (comment) by @jnothman ,

test_truncated_svd.py::test_sparse_formats
It's interesting that this is not quite covered by common tests. Apparently, we check predict and predict_proba, but not transform.

It would be useful to extend the check_estimator_sparse_data common test to also check transform when applicable. The test_truncated_svd.py::test_sparse_formats could then be removed. Also possibly other tests (git grep lil might give some indications).
@rth rth mentioned this issue Jun 24, 2019
Merged
@rth rth changed the title Add common test for sparse transform. Add common test for .transform on different sparse formats Jun 24, 2019
@thomasjpfan thomasjpfan added the module:test-suite everything related to our tests label Feb 27, 2022
@horaceklai
Copy link

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted module:test-suite everything related to our tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rth @thomasjpfan @horaceklai
0