-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
New tag: checking_init_parameters #13647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@NicolasHug I can work on this one too. Will submit a PR for the relative imports issue by today |
Let's wait for the other core devs feedback on this one. This is just an idea for now ;) |
#11324 is an attempt at this. It is somewhat orthogonal to estimator tags. It is also not necessarily as straightforward as it looks. I'm happy to see #11324 continued or superseded, but I think it needs someone with a lot of experience working with and ideally developing and testing scikit-learn estimators, so I don't have reason to believe it would be a task for you @aditya1702. |
Doesn't seem like a huge priority, closing |
Uh oh!
There was an error while loading. Please reload this page.
The default parameters of an estimator aren't necessarily the parameters with which we want to check it.
There is the
set_checking_parameters()
utility for this.It could be useful to get rid of it and introduce instead a
checking_init_parameters
tag. This way, third party estimators could also benefit from this.The text was updated successfully, but these errors were encountered: