8000 New tag: checking_init_parameters · Issue #13647 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

New tag: checking_init_parameters #13647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NicolasHug opened this issue Apr 15, 2019 · 4 comments
Closed

New tag: checking_init_parameters #13647

NicolasHug opened this issue Apr 15, 2019 · 4 comments

Comments

@NicolasHug
Copy link
Member
NicolasHug commented Apr 15, 2019 •
edited
Loading

The default parameters of an estimator aren't necessarily the parameters with which we want to check it.

There is the set_checking_parameters() utility for this.

It could be useful to get rid of it and introduce instead a checking_init_parameters tag. This way, third party estimators could also benefit from this.
@aditya1702
Copy link
Contributor

@NicolasHug I can work on this one too. Will submit a PR for the relative imports issue by today

@NicolasHug
Copy link
Member Author

Let's wait for the other core devs feedback on this one. This is just an idea for now ;)

@jnothman
Copy link
Member

#11324 is an attempt at this. It is somewhat orthogonal to estimator tags. It is also not necessarily as straightforward as it looks. I'm happy to see #11324 continued or superseded, but I think it needs someone with a lot of experience working with and ideally developing and testing scikit-learn estimators, so I don't have reason to believe it would be a task for you @aditya1702.

@NicolasHug
Copy link
Member Author

Doesn't seem like a huge priority, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jnothman @NicolasHug @aditya1702
0