8000 Provide a commit message marker to run pypy in PRs · Issue #13014 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Provide a commit message marker to run pypy in PRs #13014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Jan 18, 2019 · 7 comments
Closed

Provide a commit message marker to run pypy in PRs #13014

qinhanmin2014 opened this issue Jan 18, 2019 · 7 comments
Labels
Build / CI help wanted

Comments

@qinhanmin2014
Copy link
Member

We need to provide a commit message marker to run pypi in PRs (similar to [scipy-dev])
See https://scikit-learn.org/dev/developers/contributing.html#continuous-integration-ci
@jnothman
Copy link
Member

I think you mean pypy?

< 8000 div class="TimelineItem-badge ">
@qinhanmin2014 qinhanmin2014 changed the title Provide a commit message marker to run pypi in PRs Provide a commit message marker to run pypy in PRs Jan 19, 2019
@qinhanmin2014
Copy link
Member Author

Umm, sorry for the stupid mistake

@nixphix
Copy link
Contributor
nixphix commented Jan 20, 2019

Can I work on this ?

@jnothman
Copy link
Member
jnothman commented Jan 20, 2019 via email

@rth rth mentioned this issue Jan 20, 2019
Merged
@rth
Copy link
Member
rth commented Jan 20, 2019

In terms of implementation, unless I missed something, we may not be able to do this in the workflow definition of .circleci/config.yml directly. Solutions could be,

  1. Always run the pypy CircleCI job but it would do nothing if the right token is not present in the commit message. Probably the simplest, though I'm not so enthusiastic about having CircleCI jobs visible in the PR UI that do nothing (deploy, pypy) by default.
  2. say in the lint job, determine if pypy job needs to run by checking appropriate environment variables, then trigger it via the CircleCI API. Might be a bit more complicated to setup.

@nixphix
Copy link
Contributor
nixphix commented Jan 20, 2019

In terms of implementation, unless I missed something, we may not be able to do this in the workflow definition of .circleci/config.yml directly. Solutions could be,

  1. Always run the pypy CircleCI job but it would do nothing if the right token is not present in the commit message. Probably the simplest, though I'm not so enthusiastic about having CircleCI jobs visible in the PR UI that do nothing (deploy, pypy) by default.
  2. say in the lint job, determine if pypy job needs to run by checking appropriate environment variables, then trigger it via the CircleCI API. Might be a bit more complicated to setup.

Thanks for the tip @rth, I like the later implementation let me dig in

@nixphix nixphix mentioned this issue Jan 21, 2019
Closed
@qinhanmin2014 qinhanmin2014 mentioned this issue Feb 3, 2019
Merged
@thomasjpfan
Copy link
Member

Closing since we now run pypy test on azure which has a [pypy] marker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add [pypy] test marker for circle-ci nixphix/scikit-learn
5 participants
@jnothman @rth @nixphix @thomasjpfan @qinhanmin2014
0