8000 pypy failure on master · Issue #13009 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

pypy failure on master #13009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Jan 18, 2019 · 7 comments · Fixed by #13018
Closed

pypy failure on master #13009

qinhanmin2014 opened this issue Jan 18, 2019 · 7 comments · Fixed by #13018
Labels
Build / CI help wanted

Comments

@qinhanmin2014
Copy link
Member

Not sure what's happening but the failure persists after I rerun the job. ping @rth maybe?
See https://circleci.com/gh/scikit-learn/scikit-learn/43934

Installing collected packages: scikit-learn
  Running setup.py develop for scikit-learn
    Running command /root/project/pypy-env/bin/pypy3 -c "import setuptools, tokenize;__file__='/root/project/setup.py';f=getattr(tokenize, 'open', open)(__file__);code=f.read().replace('\r\n', '\n');f.close();exec(compile(code, __file__, 'exec'))" develop --no-deps
    Partial import of sklearn during the build process.
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/root/project/setup.py", line 243, in <module>
        setup_package()
      File "/root/project/setup.py", line 216, in setup_package
        numpy_status = get_numpy_status()
      File "/root/project/setup.py", line 149, in get_numpy_status
        import numpy
      File "/root/project/pypy-env/site-packages/numpy/__init__.py", line 142, in <module>
        from . import core
      File "/root/project/pypy-env/site-packages/numpy/core/__init__.py", line 16, in <module>
        from . import multiarray
      File "/root/project/pypy-env/site-packages/numpy/core/multiarray.py", line 44, in <module>
        arange.__module__ = 'numpy'
    AttributeError: readonly attribute '__module__'
@jnothman
Copy link
Member
jnothman commented Jan 18, 2019 via email

@rth rth mentioned this issue Jan 18, 2019
Merged
@rth
Copy link
Member
rth commented Jan 18, 2019

The relevant issue is numpy/numpy#12740 by Joel.

@adrinjalali
Copy link
Member

Do we know why this happens now?

    RefactoringTool: Refactored /tmp/pip-install-cobhy3d5/numpy/build/py3k/numpy/core/defchararray.py
    RefactoringTool: Files that were modified:
    RefactoringTool: /tmp/pip-install-cobhy3d5/numpy/build/py3k/numpy/compat/py3k.py
    RefactoringTool: /tmp/pip-install-cobhy3d5/numpy/build/py3k/numpy/core/defchararray.py
    Converting to Python3 via 2to3...
    Running from numpy source directory.Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-cobhy3d5/numpy/setup.py", line 211, in <module>
        setup_package()
      File "/tmp/pip-install-cobhy3d5/numpy/setup.py", line 188, in setup_package
        from numpy.distutils.core import setup
      File "/tmp/pip-install-cobhy3d5/numpy/build/py3k/numpy/distutils/__init__.py", line 22, in <module>
        import numpy.distutils.ccompiler
      File "/tmp/pip-install-cobhy3d5/numpy/build/py3k/numpy/distutils/ccompiler.py", line 22, in <module>
        _old_init_posix = distutils.sysconfig._init_posix
    AttributeError: module 'distutils.sysconfig' has no attribute '_init_posix'

Circle-ci+pypy fails on master with the above error.

@qinhanmin2014
Copy link
Member Author

rerun the job but still fails, reopen

@qinhanmin2014 qinhanmin2014 reopened this Jan 19, 2019
@qinhanmin2014 qinhanmin2014 changed the title pypi failure on master pypy failure on master Jan 19, 2019
@jnothman
Copy link
Member
jnothman commented Jan 19, 2019 via email

@rth rth mentioned this issue Jan 20, 2019
Merged
@rth
Copy link
Member
rth commented Jan 21, 2019 •
edited
Loading

I won't be able to look into this before tomorrow (late), so if anyone has the bandwidth and is interested feel free to push commits to #13018.

The main issue seems to be that numpy install attempts to rebuild it from sources instead of using the pre-build numpy wheels. The pinned version should work, but pinning another version might help.

I'm not so enthusiastic about using pypy nightly, because users will not use nightly, this used to work before and in the end we don't really need to run pypy with the latest numpy..

@rth
Copy link
Member
rth commented Jan 22, 2019

Do we know why this happens now?

Yes, it turns out I was trying to build numpy 1.5 (from 2010) with PyPy... Instead of 1.15 -- makes sense it didn't work and was attempting to run 2to3 (presumably to get Python 3.1 compatible code) :)

Should be fixed in #13018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Build / CI help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT Fix PyPy CI with numpy 1.15 rth/scikit-learn
4 participants
@jnothman @rth @adrinjalali @qinhanmin2014
0