8000 PyPy + scikit-learn + Jupyter in docker with 0.20 release · Issue #12243 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

PyPy + scikit-learn + Jupyter in docker with 0.20 release #12243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
giodegas opened this issue Oct 2, 2018 · 2 comments
Closed

PyPy + scikit-learn + Jupyter in docker with 0.20 release #12243

giodegas opened this issue Oct 2, 2018 · 2 comments

Comments

@giodegas
Copy link
giodegas commented Oct 2, 2018

I tested the new release scikit-0.20 with y docker pypy+jupyter container.

sklearn_test_setup.log

I have got:

 1 failed, 9922 passed, 29 skipped, 66 xfailed, 5 xpassed, 932 warnings in 1202.58 seconds

Great! 👍

Full log file:
sklearn_test.log

@rth do you think I shall publish it as final?
Thank you.
@giodegas giodegas mentioned this issue Oct 2, 2018
Merged
@rth
Copy link
Member
rth commented Oct 2, 2018

Thanks for the report @giodegas! Yes, you can ignore the test failure in test_import_sklearn_no_warnings. Publishing it as final sounds good!

Unrelated but we should remove that test altogether, it actually never fails, just shows warnings and here the failure is due to,

        try:
            [...]
            message = subprocess.check_output(['python', '-Wdefault',
                                               '-c', import_modules],
                                               stderr=subprocess.STDOUT)
        except Exception as e:
            pytest.skip('soft-failed test_import_sklearn_no_warnings.\n'
>                       ' %s, \n %s' % (e, message))
E           UnboundLocalError: local variable 'message' referenced before assignment

usr/local/site-packages/sklearn/tests/test_init.py:61: UnboundLocalError

i.e. we don't handle well the caught exception..

@rth rth mentioned this issue Oct 2, 2018
Merged
@qinhanmin2014
Copy link
Member

@giodegas We've removed that test in #12244 and the change is likely to be included in 0.20.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rth @giodegas @qinhanmin2014
0