8000 Minimal numpy and scipy versions for 0.21 · Issue #12184 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Minimal numpy and scipy versions for 0.21 #12184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
2 tasks
rth opened this issue Sep 27, 2018 · 3 comments
Closed
2 tasks

Minimal numpy and scipy versions for 0.21 #12184

rth opened this issue Sep 27, 2018 · 3 comments
Milestone
0.21

Comments

@rth
Copy link
Member
rth commented Sep 27, 2018 •
edited
Loading

Assuming the next 0.21 release happens around or after April 2019, the oldest Ubuntu LTS at that point will be 16.04 LTS, which includes,

  • numpy 1.11.0
  • scipy 0.17.0

(checked in a Docker image, not sure where to find the official information)

so we could probably make these our minimum requirements for 0.21.

Making so would for instance allow to implement #11638

Even assuming there is agreement on this subject, we should probably wait for 0.20.1, at least, before doing anything about it. Eventually this would involve,

  • adjusting versions of dependencies in docs and CI
  • removing the utils.fixes that are no longer needed.
@rth rth added this to the 0.21 milestone Sep 27, 2018
@rth rth mentioned this issue Sep 27, 2018
Closed
@ogrisel
Copy link
Member
ogrisel commented Sep 28, 2018

I would also be in favor of bumping dependencies for scikit-learn 0.21 to those matching ubuntu 16.04 LTS so as to be able to implement what is described in #11638.

@amueller
Copy link
Member

+1 on bumping and +1 on waiting for 0.20.1

@jakirkham jakirkham mentioned this issue Sep 29, 2018
Closed
This was referenced Oct 1, 2018
Merged
Merged
@rth rth mentioned this issue Nov 5, 2018
Closed
@rth rth mentioned this issue Dec 5, 2018
Merged
@qinhanmin2014
Copy link
Member

From #12718
We should also consider the version of matplotlib and scikit-image
It's 1.5.1 for matplotlib (https://packages.ubuntu.com/xenial/python3-matplotlib) and 0.10.1 for scikit-image (https://packages.ubuntu.com/xenial/python3-skimage).

@jeremiedbb jeremiedbb mentioned this issue Dec 6, 2018
Merged
@qinhanmin2014 qinhanmin2014 mentioned this issue Dec 10, 2018
Merged
@qinhanmin2014 qinhanmin2014 mentioned this issue Mar 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21
Development

No branches or pull requests
4 participants
@ogrisel @amueller @rth @qinhanmin2014
0