8000 Breaking BaseSearchCV inheritance with abstract method · Issue #12173 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Breaking BaseSearchCV inheritance with abstract method #12173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Sep 26, 2018 · 3 comments
Closed

Breaking BaseSearchCV inheritance with abstract method #12173

amueller opened this issue Sep 26, 2018 · 3 comments
Milestone
0.20.1

Comments

@amueller
Copy link
Member

#9599 introduces an abstract method on BaseSearchCV. If someone inherited from BaseSearchCV and redefined fit (like skopt.BayesSearchCV) this will break.

I think maybe we should not make this abstract and instead just raise a NotImplementedError.

See #9599 (comment).
@amueller amueller added this to the 0.20.1 milestone Sep 26, 2018
@adrinjalali
Copy link
Member

Could I give this a try?

@amueller
9E4C
Copy link
Member Author

You can. I'm not sure @jnothman agrees with the solution, though ;)

@jnothman
Copy link
Member

Sounds good to me.

@adrinjalali adrinjalali mentioned this issue Sep 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.1
Development

No branches or pull requests
3 participants
@jnothman @amueller @adrinjalali
0