10000 OPTICS metric param docstring and parameter handling needs improvements · Issue #12009 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

OPTICS metric param docstring and parameter handling needs improvements #12009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adrinjalali opened this issue Sep 5, 2018 · 1 comment · Fixed by #12028
Closed

OPTICS metric param docstring and parameter handling needs improvements #12009

adrinjalali opened this issue Sep 5, 2018 · 1 comment · Fixed by #12028
Labels
Documentation help wanted

Comments

@adrinjalali
Copy link
Member

As also reported in #11954, the OPTICS docstring for metric includes values which are not supported, and also is missing values which are already supported.

The docstring needs to actually include the supported ones, and since the metric is used calling two different modules, OPTICS should probably check if the given value is in the intersection of their supported ones.
@jnothman
Copy link
Member
jnothman commented Sep 6, 2018

Yes, this is where having two different pairwise metric implementations really becomes a mess! :(

This was referenced Sep 6, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG+1] Fix optics metric issues (DOC and precomputed) adrinjalali/scikit-learn
3 participants
@jnothman @adrinjalali @qinhanmin2014
0