-
-
Notifications
You must be signed in to change notification settings - Fork 25.9k
BallTree.data is a memory view #11728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I haven't worked with Cython before. Are you just suggesting to cast the memory view as a numpy array when Or is there a cleaner way to do this? |
This is not as simple as that. In Is it not possible to just change the doc and document data as a memoryview ? |
Yes, also in So we could, refactor BinaryTree, BallTree etc to use the In the end though, |
Via stackoverflow.
BallTree.data
is documented as numpy array but is instead a memory view. I haven't looked at the code, but I think we should store it as a numpy array and if that results in any efficiency issues, we can make it private instead.The text was updated successfully, but these errors were encountered: