8000 Circle CI failure and Travis cron job failure · Issue #11697 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Circle CI failure and Travis cron job failure #11697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
qinhanmin2014 opened this issue Jul 27, 2018 · 12 comments · Fixed by #11701
Closed

Circle CI failure and Travis cron job failure #11697

qinhanmin2014 opened this issue Jul 27, 2018 · 12 comments · Fixed by #11701
Labels
Blocker Build / CI help wanted
Milestone
0.20

Comments

@qinhanmin2014
Copy link
Member

Circle CI failure:
Seems that it's due to e888c0d, but I cannot figure out the reason.

Travis cron job failure:
See e.g., https://travis-ci.org/scikit-learn/scikit-learn/builds/408877802
Typical log:
FutureWarning: Using a non-tuple sequence for multidimensional indexing is deprecated; use
arr[tuple(seq)] instead of arr[seq]. In the future this will be interpreted as an array index,
arr[np.array(seq)], which will result either in an error or a different result.
@qinhanmin2014 qinhanmin2014 added this to the 0.20 milestone Jul 27, 2018
@zjpoh
Copy link
Contributor
zjpoh commented Jul 27, 2018

The problems seems to be FutureWarning, which are treated as exception. Basically just making changes according to the FutureWarning will solves the problem.

I had that problem in #11628.

@qinhanmin2014
Copy link
Member Author

Thanks @zjpoh PR welcomed.

@naoyak naoyak mentioned this issue Jul 28, 2018
Merged
@jnothman
Copy link
Member
jnothman commented Jul 29, 2018 via email

@jnothman
Copy link
Member
jnothman commented Jul 29, 2018 via email

@jnothman jnothman reopened this Jul 29, 2018
@jnothman
Copy link
Member

I got confused that this was only an issue in the CRON / latest dev versions.

@naoyak there are several other instances in the Travis log

  • in birch: node1_dist, node2_dist = dist[[farthest_idx]]
  • in scipy.stats.scoreatpercentile called from elliptic_envelope.py and gradient_boosting.py and iforest.py and lof.py and univariate_selection.py. We can use numpy.percentile in all those cases instead, I think.
  • in test_extract_patches_strided with assert_true((patches[[slice(-1, None, None)] * ndim] == image[last_patch_slices].squeeze()).all()) (looks like it's happening twice here)

@naoyak are you up to fixing these?

@naoyak naoyak mentioned this issue Jul 29, 2018
Merged
@naoyak
Copy link
Contributor
naoyak commented Jul 29, 2018

@jnothman see #11704. Is the dev build supposed to install latest SciPy master? It looks like it installs 1.1.0 - the percentileofscore issue is fixed in master (scipy/scipy@1955c60).

@jnothman
Copy link
Member
jnothman commented Jul 29, 2018 via email

@naoyak
Copy link
Contributor
naoyak commented Jul 29, 2018 •
edited
Loading

Oh you know what, it's because there aren't nightly wheels for Python 3.7 available aside from numpy, at least at the URL passed to pip. So it reverts to installing the latest release from PyPI.

@naoyak naoyak mentioned this issue Jul 30, 2018
Merged
@naoyak
Copy link
Contributor
naoyak commented Jul 30, 2018

Hopefully this will go away with MacPython/scipy-wheels#33.

@qinhanmin2014
Copy link
Member Author

Thanks a lot @naoyak
I'll close once Travis (cron job) passes

@naoyak
Copy link
Contributor
naoyak commented Jul 31, 2018

Looks like we're set here. https://travis-ci.org/scikit-learn/scikit-learn/builds/410251283#L2360-L2361

@jnothman
Copy link
Member
jnothman commented Jul 31, 2018 via email

@qinhanmin2014 qinhanmin2014 mentioned this issue Nov 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Blocker Build / CI help wanted
Projects
None yet
Milestone
0.20
Development

Successfully merging a pull request may close this issue.

Use tuple indices to access ndarray and avoid numpy FutureWarning naoyak/scikit-learn
4 participants
@jnothman @naoyak @zjpoh @qinhanmin2014
0