8000 Remove occurences of imread/imresize · Issue #10499 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Remove occurences of imread/imresize #10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lesteve opened this issue Jan 18, 2018 · 3 comments · Fixed by #10502
Closed

Remove occurences of imread/imresize #10499

lesteve opened this issue Jan 18, 2018 · 3 comments · Fixed by #10502
Labels
Easy Well-defined and straightforward way to resolve help wanted

Comments

@lesteve
Copy link
Member
lesteve commented Jan 18, 2018

Follow-up of #10427 (comment)

There are some remaining occurences of imread/imresize in doc and examples:

❯ git grep -P 'imread|imresize' | grep -v sklearn
doc/datasets/index.rst:* `scipy.misc.imread <https://docs.scipy.org/doc/scipy/reference/generated/scipy.
doc/datasets/index.rst:  misc.imread.html#scipy.misc.imread>`_ (requires the `Pillow
examples/classification/plot_digits_classification.py:# matplotlib.pyplot.imread.  Note that each image must have the same size. For these
examples/cluster/plot_face_segmentation.py:face = sp.misc.imresize(face, 0.10) / 255.
examples/cluster/plot_face_ward_segmentation.py:face = sp.misc.imresize(face, 0.10) / 255.

The pyplot.imread is fine. It's probably fine removing the mentions in index.rst and pointing to an alternative (maybe matplotlib.pyplot.imread?). For the examples, the simplest thing to do is to use sklearn.external._pilutil.imresize.

@jotasi since you worked on #10427, it would be great if you could tackle this one!
@lesteve lesteve added Easy Well-defined and straightforward way to resolve help wanted labels Jan 18, 2018
@thelastpolaris
Copy link

Hello. I can work on this issue if @jotasi doesn't mind.

@jotasi
Copy link
jotasi commented Jan 18, 2018

Hi, thanks for the ping @lesteve.
I was planning on taking care of this tomorrow morning, although I don't want to steal any work from you @thelastpolaris.

@jnothman
Copy link
Member
jnothman commented Jan 19, 2018 via email

@jotasi jotasi mentioned this issue Jan 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MRG] Removed ref. to deprecated imread/imresize in docs jotasi/scikit-learn
4 participants
@jnothman @lesteve @thelastpolaris @jotasi
0