8000 load_sample_images uses deprecated imread · Issue #10147 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

load_sample_images uses deprecated imread #10147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
amueller opened this issue Nov 15, 2017 · 11 comments · Fixed by #10427
Closed

load_sample_images uses deprecated imread #10147

amueller opened this issue Nov 15, 2017 · 11 comments · Fixed by #10427
Labels
Easy Well-defined and straightforward way to resolve help wanted

Comments

@amueller
Copy link
Member

DeprecationWarning: imread is deprecated!
imread is deprecated in SciPy 1.0.0, and will be removed in 1.2.0.
@amueller amueller added Easy Well-defined and straightforward way to resolve help wanted labels Nov 15, 2017
@keyur9
Copy link
keyur9 commented Nov 15, 2017

@amueller I'm interested in working on this issue. May I know if you could share more details?

@amueller
Copy link
Member Author

The imread function in scipy is deprecated, therefore we should not use it. I'm not sure if it's replaced by anything, or if we need to use PIL/pillow directly.

@keyur9
Copy link
keyur9 commented Nov 15, 2017

As per the Scipy document, imread is deprecated and it is suggested to use imageio.imread instead. Please share your thoughts if imageio.imread is fine or you would suggest using PIL/pillow directly?

@amueller
Copy link
Member Author

Hm... I guess we use pillow directly? @GaelVaroquaux @jnothman opinions?

@jnothman
Copy link
Member
jnothman commented Nov 15, 2017 via email

@keyur9 keyur9 mentioned this issue Nov 16, 2017
Closed
@keyur9
Copy link
keyur9 commented Nov 16, 2017 •
edited
Loading

Thank you for the suggestion @jnothman. As suggested, have implemented the changes and created the PR.

@glemaitre
Copy link
Member

I got something similar for basic image processing included in LFW fetcher:

`imresize` is deprecated in SciPy 1.0.0, and will be removed in 1.2.0.
Use ``skimage.transform.resize`` instead.

Do we want to keep using PIL in this case (http://pillow.readthedocs.io/en/4.3.x/reference/Image.html#PIL.Image.Image.resize)?

@jotasi
Copy link
jotasi commented Dec 11, 2017

Is there anyone currently working on this? The pull request by @keyur9 seems to be incomplete and inactive. I would love to take a shot at this but I don't want to step on anyone's toes.

@keyur9
Copy link
keyur9 commented Dec 12, 2017

Hello @jotasi , feel free to work on this as I'll not be able to work on this until the weekend. Thank you,

@jotasi jotasi mentioned this issue Jan 8, 2018
Merged
@Siohey
Copy link
Siohey commented Dec 5, 2018

we can use imread() like imageio.imread().
First you should install imageio package.
import imageio
picture = imageio.imread( 'XXX.png')

@kersonp
Copy link
kersonp commented Jan 22, 2019

thanks Siohey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Easy Well-defined and straightforward way to resolve help wanted
Projects
None yet
Milestone
No milestone
7 participants
@jnothman @amueller @glemaitre @keyur9 @jotasi @kersonp @Siohey
0