Use more `assert` for checking the variable properties. #31920

lionelkusch · 2025-08-11T08:53:39Z

lionelkusch
Aug 11, 2025

By looking at the code, I see that most of the checks of the variable are based on the next schema:

 if .....
         raise ValueError( ... )

For example,

scikit-learn/sklearn/neighbors/_nca.py

Lines 248 to 292 in 24844a0

    
           if self.n_components is not None and self.n_components > X.shape[1]: 
        
               raise ValueError( 
        
                   "The preferred dimensionality of the " 
        
                   f"projected space `n_components` ({self.n_components}) cannot " 
        
                   "be greater than the given data " 
        
                   f"dimensionality ({X.shape[1]})!" 
        
               ) 
        
           # If warm_start is enabled, check that the inputs are consistent 
        
           if ( 
        
               self.warm_start 
        
               and hasattr(self, "components_") 
        
               and self.components_.shape[1] != X.shape[1] 
        
           ): 
        
               raise ValueError( 
        
                   f"The new inputs dimensionality ({X.shape[1]}) does not " 
        
                   "match the input dimensionality of the " 
        
                   f"previously learned transformation ({self.components_.shape[1]})." 
        
               ) 
        
           # Check how the linear transformation should be initialized 
        
           init = self.init 
        
           if isinstance(init, np.ndarray): 
        
               init = check_array(init) 
        
               # Assert that init.shape[1] = X.shape[1] 
        
               if init.shape[1] != X.shape[1]: 
        
                   raise ValueError( 
        
                       f"The input dimensionality ({init.shape[1]}) of the given " 
        
                       "linear transformation `init` must match the " 
        
                       f"dimensionality of the given inputs `X` ({X.shape[1]})." 
        
                   ) 
        
               # Assert that init.shape[0] <= init.shape[1] 
        
               if init.shape[0] > init.shape[1]: 
        
                   raise ValueError( 
        
                       f"The output dimensionality ({init.shape[0]}) of the given " 
        
                       "linear transformation `init` cannot be " 
        
                       f"greater than its input dimensionality ({init.shape[1]})." 
        
                   ) 
        
               # Assert that self.n_components = init.shape[0] 
        
               if self.n_components is not None and self.n_components != init.shape[0]: 
        
                   raise ValueError( 
        
                       "The preferred dimensionality of the " 
        
                       f"projected space `n_components` ({self.n_components}) does" 
        
                       " not match the output dimensionality of " 
        
                       "the given linear transformation " 
        
                       f"`init` ({init.shape[0]})!" 
        
                   )

I am wondering why the assertion is not used in this case.
The advantage of assertion is that there can be deactivate it by option "-O" of python and it can increase the speed of execution of a program, especially in the case of a pipeline.

Mohataseem89 · 2025-12-12T15:56:50Z

Mohataseem89
Dec 12, 2025

assert isn't used for input validation in scikit-learn because assertions can be disabled with -O, which would skip important checks and break API guarantees. ValueError/TypeError are used intentionally so validation always runs.

0 replies

lionelkusch · 2025-12-14T21:01:00Z

lionelkusch
Dec 14, 2025
Author

This is the point of using assertions: to disable the checks when they're not required.
Once you are sure of what you are doing, we should have a way to speed up the calculation by removing the check especially when we are doing hyperparameter optimisation.

0 replies

This comment was marked as spam.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Use more `assert` for checking the variable properties. #31920

Uh oh!

{{title}}

Uh oh!

Replies: 3 comments

This comment was marked as spam.

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

Uh oh!

Use more assert for checking the variable properties. #31920

Uh oh!

lionelkusch Aug 11, 2025

Replies: 3 comments

This comment was marked as spam.

Uh oh!

Mohataseem89 Dec 12, 2025

Uh oh!

lionelkusch Dec 14, 2025 Author

Use more `assert` for checking the variable properties. #31920

lionelkusch
Aug 11, 2025

Mohataseem89
Dec 12, 2025

lionelkusch
Dec 14, 2025
Author