8000 MAINT Parameter Validation for feature_selection.chi2 (#25719) · scikit-learn/scikit-learn@f9ee1b4 · GitHub
[go: up one dir, main page]

Skip to content

Commit f9ee1b4

Browse files
MAINT Parameter Validation for feature_selection.chi2 (#25719)
Co-authored-by: jeremiedbb <jeremiedbb@yahoo.fr>
1 parent de67a44 commit f9ee1b4

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

sklearn/feature_selection/_univariate_selection.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from ..utils import as_float_array, check_array, check_X_y, safe_sqr, safe_mask
1818
from ..utils.extmath import safe_sparse_dot, row_norms
1919
from ..utils.validation import check_is_fitted
20-
from ..utils._param_validation import Interval, StrOptions
20+
from ..utils._param_validation import Interval, StrOptions, validate_params
2121
from ._base import SelectorMixin
2222

2323

@@ -167,6 +167,12 @@ def _chisquare(f_obs, f_exp):
167167
return chisq, special.chdtrc(k - 1, chisq)
168168

169169

170+
@validate_params(
171+
{
172+
"X": ["array-like", "sparse matrix"],
173+
"y": ["array-like"],
174+
}
175+
)
170176
def chi2(X, y):
171177
"""Compute chi-squared stats between each non-negative feature and class.
172178

sklearn/tests/test_public_functions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,7 @@ def _check_function_param_validation(
112112
"sklearn.feature_extraction.img_to_graph",
113113
"sklearn.feature_extraction.image.extract_patches_2d",
114114
"sklearn.feature_extraction.image.reconstruct_from_patches_2d",
115+
"sklearn.feature_selection.chi2",
115116
"sklearn.metrics.accuracy_score",
116117
"sklearn.metrics.auc",
117118
"sklearn.metrics.average_precision_score",

0 commit comments

Comments
 (0)
0