8000 CLN address review comments · scikit-learn/scikit-learn@f33bba5 · GitHub
[go: up one dir, main page]
Skip to content

Commit f33bba5

Browse files
lorentzenchrlorentzenchr
committed
CLN address review comments
1 parent 6604d47 commit f33bba5

File tree

3 files changed

+58
-56
lines changed

3 files changed

+58
-56
lines changed

‎doc/modules/classes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1648,7 +1648,7 @@ To be removed in 1.0 (renaming of 0.25)
16481648

16491649
.. _loss_function_ref:
16501650

1651-
:mod:`sklearn._loss`: Non-public Loss Function Classes
1651+
:mod:`sklearn._loss`: Private Loss Function Classes
16521652
===========================================================
16531653

16541654
.. automodule:: sklearn._loss

‎sklearn/_loss/_loss.pxd

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ ctypedef fused G_DTYPE_C:
1919

2020

2121
# Struct to return 2 doubles
22-
ctypedef struct double2:
22+
ctypedef struct double_pair:
2323
double val1
2424
double val2
2525

@@ -28,48 +28,48 @@ ctypedef struct double2:
2828
cdef class cLossFunction:
2929
cdef double closs(self, double y_true, double raw_prediction) nogil
3030
cdef double cgradient(self, double y_true, double raw_prediction) nogil
31-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
31+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
3232

3333

3434
cdef class cHalfSquaredError(cLossFunction):
3535
cdef double closs(self, double y_true, double raw_prediction) nogil
3636
cdef double cgradient(self, double y_true, double raw_prediction) nogil
37-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
37+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
3838

3939

4040
cdef class cAbsoluteError(cLossFunction):
4141
cdef double closs(self, double y_true, double raw_prediction) nogil
4242
cdef double cgradient(self, double y_true, double raw_prediction) nogil
43-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
43+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
4444

4545

4646
cdef class cPinballLoss(cLossFunction):
4747
cdef readonly double quantile # readonly makes it inherited by children
4848
cdef double closs(self, double y_true, double raw_prediction) nogil
4949
cdef double cgradient(self, double y_true, double raw_prediction) nogil
50-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
50+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
5151

5252

5353
cdef class cHalfPoissonLoss(cLossFunction):
5454
cdef double closs(self, double y_true, double raw_prediction) nogil
5555
cdef double cgradient(self, double y_true, double raw_prediction) nogil
56-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
56+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
5757

5858

5959
cdef class cHalfGammaLoss(cLossFunction):
6060
cdef double closs(self, double y_true, double raw_prediction) nogil
6161
cdef double cgradient(self, double y_true, double raw_prediction) nogil
62-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
62+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
6363

6464

6565
cdef class cHalfTweedieLoss(cLossFunction):
6666
cdef readonly double power # readonly makes it inherited by children
6767
cdef double closs(self, double y_true, double raw_prediction) nogil
6868
cdef double cgradient(self, double y_true, double raw_prediction) nogil
69-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
69+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil
7070

7171

7272
cdef class cBinaryCrossEntropy(cLossFunction):
7373
cdef double closs(self, double y_true, double raw_prediction) nogil
7474
cdef double cgradient(self, double y_true, double raw_prediction) nogil
75-
cdef double2 cgrad_hess(self, double y_true, double raw_prediction) nogil
75+
cdef double_pair cgrad_hess(self, double y_true, double raw_prediction) nogil

0 commit comments

Comments
 (0)
0