BLD Improve make clean for edge case situations (#29413)

lesteve · betatim · web-flow · commit dd88e21dcc9f · 2024-07-04T13:01:02.000+02:00
Co-authored-by: Tim Head &lt;betatim@gmail.com&gt;
diff --git a/Makefile b/Makefile
@@ -1,6 +1,7 @@
 # simple makefile to simplify repetitive build env management tasks under posix
 
 PYTHON ?= python
+DEFAULT_MESON_BUILD_DIR = build/cp$(shell python -c 'import sys; print(f"{sys.version_info.major}{sys.version_info.minor}")' )
 
 all:
 	@echo "Please use 'make <target>' where <target> is one of"
@@ -21,6 +22,11 @@ clean: clean-meson
 
 clean-meson:
 	pip uninstall -y scikit-learn
+	# It seems in some cases removing the folder avoids weird compilation
+	# errors (e.g. when switching from numpy>=2 to numpy<2). For some 
+	# reason ninja clean -C $(DEFAULT_MESON_BUILD_DIR) is not
+	# enough
+	rm -rf $(DEFAULT_MESON_BUILD_DIR)
 
 dev-setuptools:
 	$(PYTHON) setup.py build_ext -i
