Merge branch 'array_API_cosine_distance' of github.com:EmilyXinyi/scikit-learn into array_API_cosine_distance

EmilyXinyi · EmilyXinyi · commit da921c459a09 · 2024-07-08T14:36:13.000+02:00
diff --git a/sklearn/metrics/pairwise.py b/sklearn/metrics/pairwise.py
@@ -1127,7 +1127,7 @@ def cosine_distances(X, Y=None):
     S = cosine_similarity(X, Y)
     S *= -1
     S += 1
-    S = _clip(X, S, 0, 2, xp)
+    S = _clip(S, 0, 2, xp)
     if X is Y or Y is None:
         # Ensure that distances between vectors and themselves are set to 0.0.
         # This may not be the case due to floating point rounding errors.
diff --git a/sklearn/utils/_array_api.py b/sklearn/utils/_array_api.py
@@ -752,7 +752,7 @@ def _nanmax(X, axis=None, xp=None):
         return X
 
 
-def _clip(X, S, min_val, max_val, xp):
+def _clip(S, min_val, max_val, xp):
     # TODO: remove this method and change all usage once we move to array api 2023.12
     # https://data-apis.org/array-api/2023.12/API_specification/generated/array_api.clip.html#clip
     if _is_numpy_namespace(xp):
