8000 Make the check changelog message more explicit · scikit-learn/scikit-learn@d7cecb3 · GitHub
[go: up one dir, main page]

Skip to content

Commit d7cecb3

Browse files
ogriselTomDLT
authored andcommitted
Make the check changelog message more explicit
1 parent 907c093 commit d7cecb3

File tree

1 file changed

+18
-5
lines changed

1 file changed

+18
-5
lines changed

.github/workflows/check-changelog.yml

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,27 @@ jobs:
4141
else
4242
echo "Changelog and milestone do not correspond."
4343
echo "If you see this error make sure that the tagged milestone for the PR"
44-
echo "and the changelog name properly match."
44+
echo "and the edited changelog filename properly match."
4545
exit 1
4646
fi
4747
fi
4848
else
49-
echo "Changelog entry is missing."
50-
echo "If you see this error and there is already a changelog entry then make sure that"
51-
echo "the PR number is correct. If no changelog entry is required for this PR,"
52-
echo "label the PR with 'No Changelog Needed' to bypass this check."
49+
echo "A Changelog entry is missing."
50+
echo ""
51+
echo "Please add an entry to the changelog at 'doc/whats_new/v*.rst'"
52+
echo "to document your change assuming that the PR will be merged"
53+
echo "in time for the next release of scikit-learn."
54+
echo ""
55+
echo "Look at other entries in that file for inspiration and please"
56+
echo "reference this pull request using the ':pr:' directive and"
57+
echo "credit yourself (and other contributors if applicable) with"
58+
echo "the ':user:' directive."
59+
echo ""
60+
echo "If you see this error and there is already a changelog entry,"
61+
echo "check that the PR number is correct."
62+
echo ""
63+
echo" If you believe that this PR does no warrant a changelog"
64+
echo "entry, say so in a comment so that a maintainer will label "
65+
echo "the PR with 'No Changelog Needed' to bypass this check."
5366
exit 1
5467
fi

0 commit comments

Comments
 (0)
0