MAINT force NumPy version for building scikit-learn for CPython 3.10 in Windows (#24742)

glemaitre · ogrisel · thomasjpfan · web-flow · commit a71c5353e2c8 · 2022-10-25T08:12:20.000+02:00
Co-authored-by: Olivier Grisel &lt;olivier.grisel@ensta.org&gt;
Co-authored-by: Thomas J. Fan &lt;thomasjpfan@gmail.com&gt;
diff --git a/pyproject.toml b/pyproject.toml
@@ -9,7 +9,12 @@ requires = [
     # wheels on PyPI
     #
     # see: https://github.com/scipy/oldest-supported-numpy/blob/main/setup.cfg
-    "oldest-supported-numpy",
+    "oldest-supported-numpy; python_version!='3.10' or platform_system!='Windows' or platform_python_implementation=='PyPy'",
+    # For CPython 3.10 under Windows, SciPy requires NumPy 1.22.3 while the
+    # oldest supported NumPy is defined as 1.21.6. We therefore need to force
+    # it for this specific configuration. For details, see
+    # https://github.com/scipy/scipy/blob/c58b608c83d30800aceee6a4dab5c3464cb1de7d/pyproject.toml#L38-L41
+    "numpy==1.22.3; python_version=='3.10' and platform_system=='Windows' and platform_python_implementation != 'PyPy'",
 
     "scipy>=1.3.2",
 ]

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,12 @@ requires = [`
`9`	`9`	`# wheels on PyPI`
`10`	`10`	`#`
`11`	`11`	`# see: https://github.com/scipy/oldest-supported-numpy/blob/main/setup.cfg`
`12`		`- "oldest-supported-numpy",`
	`12`	`+ "oldest-supported-numpy; python_version!='3.10' or platform_system!='Windows' or platform_python_implementation=='PyPy'",`
	`13`	`+ # For CPython 3.10 under Windows, SciPy requires NumPy 1.22.3 while the`
	`14`	`+ # oldest supported NumPy is defined as 1.21.6. We therefore need to force`
	`15`	`+ # it for this specific configuration. For details, see`
	`16`	`+ # https://github.com/scipy/scipy/blob/c58b608c83d30800aceee6a4dab5c3464cb1de7d/pyproject.toml#L38-L41`
	`17`	`+ "numpy==1.22.3; python_version=='3.10' and platform_system=='Windows' and platform_python_implementation != 'PyPy'",`
`13`	`18`
`14`	`19`	`"scipy>=1.3.2",`
`15`	`20`	`]`