MAINT Parameters validation for datasets.make_low_rank_matrix (#25901)

Théophile Baranger · web-flow · commit 940303ccab61 · 2023-03-21T12:57:19.000+01:00
diff --git a/sklearn/datasets/_samples_generator.py b/sklearn/datasets/_samples_generator.py
@@ -1198,6 +1198,15 @@ def make_friedman3(n_samples=100, *, noise=0.0, random_state=None):
     return X, y
 
 
+@validate_params(
+    {
+        "n_samples": [Interval(Integral, 1, None, closed="left")],
+        "n_features": [Interval(Integral, 1, None, closed="left")],
+        "effective_rank": [Interval(Integral, 1, None, closed="left")],
+        "tail_strength": [Interval(Real, 0, 1, closed="both")],
+        "random_state": ["random_state"],
+    }
+)
 def make_low_rank_matrix(
     n_samples=100,
     n_features=100,
diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -132,6 +132,7 @@ def _check_function_param_validation(
     "sklearn.datasets.make_circles",
     "sklearn.datasets.make_classification",
     "sklearn.datasets.make_friedman1",
+    "sklearn.datasets.make_low_rank_matrix",
     "sklearn.datasets.make_sparse_coded_signal",
     "sklearn.decomposition.sparse_encode",
     "sklearn.feature_extraction.grid_to_graph",
