8000 remove special case for BaggingEstimator after merge of #4137 · scikit-learn/scikit-learn@8cf714c · GitHub
[go: up one dir, main page]

Skip to content

Commit 8cf714c

Browse files
committed
remove special case for BaggingEstimator after merge of #4137
1 parent 8f2780f commit 8cf714c

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

sklearn/utils/estimator_checks.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
from sklearn.utils.testing import SkipTest
2525
from sklearn.utils.testing import check_skip_travis
2626
from sklearn.utils.testing import ignore_warnings
27-
from sklearn.utils.testing import assert_raise_message
2827

2928
from sklearn.base import clone, ClassifierMixin
3029
from sklearn.metrics import accuracy_score, adjusted_rand_score, f1_score
@@ -338,13 +337,8 @@ def check_estimators_dtypes(name, Estimator):
338337

339338
for method in ["predict", "transform", "decision_function",
340339
"predict_proba"]:
341-
try:
342-
if hasattr(estimator, method):
343-
getattr(estimator, method)(X_train)
344-
except NotImplementedError:
345-
# FIXME
346-
# non-standard handling of ducktyping in BaggingEstimator
347-
pass
340+
if hasattr(estimator, method):
341+
getattr(estimator, method)(X_train)
348342

349343

350344
def check_estimators_empty_data_messages(name, Estimator):

0 commit comments

Comments
 (0)
0