ENH Replace *args with named arguments in make_union (#17472)

jaketae · thomasjpfan · IQRA MUHAMMAD · web-flow · commit 6df781b0c34b · 2020-06-07T13:40:10.000-04:00
Co-authored-by: Thomas J. Fan &lt;thomasjpfan@gmail.com&gt;
Co-authored-by: IQRA MUHAMMAD &lt;iqra@iqra.local&gt;
diff --git a/sklearn/pipeline.py b/sklearn/pipeline.py
@@ -1013,7 +1013,7 @@ def _sk_visual_block_(self):
         return _VisualBlock('parallel', transformers, names=names)
 
 
-def make_union(*transformers, **kwargs):
+def make_union(*transformers, n_jobs=None, verbose=False):
     """
     Construct a FeatureUnion from the given transformers.
 
@@ -1055,12 +1055,5 @@ def make_union(*transformers, **kwargs):
      FeatureUnion(transformer_list=[('pca', PCA()),
                                    ('truncatedsvd', TruncatedSVD())])
     """
-    n_jobs = kwargs.pop('n_jobs', None)
-    verbose = kwargs.pop('verbose', False)
-    if kwargs:
-        # We do not currently support `transformer_weights` as we may want to
-        # change its type spec in make_union
-        raise TypeError('Unknown keyword arguments: "{}"'
-                        .format(list(kwargs.keys())[0]))
     return FeatureUnion(
         _name_estimators(transformers), n_jobs=n_jobs, verbose=verbose)
diff --git a/sklearn/tests/test_pipeline.py b/sklearn/tests/test_pipeline.py
@@ -519,7 +519,8 @@ def test_make_union_kwargs():
     # invalid keyword parameters should raise an error message
     assert_raise_message(
         TypeError,
-        'Unknown keyword arguments: "transformer_weights"',
+        "make_union() got an unexpected "
+        "keyword argument 'transformer_weights'",
         make_union, pca, mock, transformer_weights={'pca': 10, 'Transf': 1}
     )
 

Original file line number	Diff line number	Diff line change
`@@ -519,7 +519,8 @@ def test_make_union_kwargs():`
`519`	`519`	`# invalid keyword parameters should raise an error message`
`520`	`520`	`assert_raise_message(`
`521`	`521`	`TypeError,`
`522`		`- 'Unknown keyword arguments: "transformer_weights"',`
	`522`	`+ "make_union() got an unexpected "`
	`523`	`+ "keyword argument 'transformer_weights'",`
`523`	`524`	`make_union, pca, mock, transformer_weights={'pca': 10, 'Transf': 1}`
`524`	`525`	`)`
`525`	`526`