8000 GOV more pragmatic decision making process for small PRs (#31430) · scikit-learn/scikit-learn@651a4ae · GitHub
[go: up one dir, main page]

Skip to content

Commit 651a4ae

Browse files
authored
GOV more pragmatic decision making process for small PRs (#31430)
1 parent 5430920 commit 651a4ae

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

doc/governance.rst

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,20 +146,22 @@ decision making process**".
146146
Decisions (in addition to adding core contributors and TC membership as above)
147147
are made according to the following rules:
148148

149-
* **Minor Documentation changes**, such as typo fixes, or addition / correction
149+
* **Minor code and documentation changes**, such as small maintenance changes without
150+
modification of code logic, typo fixes, or addition / correction
150151
of a sentence, but no change of the ``scikit-learn.org`` landing page or the
151-
“about” page: Requires +1 by a maintainer, no -1 by a maintainer (lazy
152-
consensus), happens on the issue or pull request page. Maintainers are
153-
expected to give “reasonable time” to others to give their opinion on the
152+
“about” page: Requires +1 by a core contributor, no -1 by a core contributor
153+
(lazy consensus), happens on the issue or pull request page. Core contributors
154+
are expected to give “reasonable time” to others to give their opinion on the
154155
pull request if they're not confident others would agree.
155156

156157
* **Code changes and major documentation changes**
157-
require +1 by two maintainers, no -1 by a maintainer (lazy
158+
require +1 by two core contributors, no -1 by a core contributor (lazy
158159
consensus), happens on the issue of pull-request page.
159160

160161
* **Changes to the API principles and changes to dependencies or supported
161-
versions** happen via :ref:`slep` and follows the decision-making process
162-
outlined above.
162+
versions** follow the decision-making process outlined above. In particular
163+
changes to API principles are backed via a :ref:`slep`. Smaller decisions
164+
like supported versions can happen on a GitHub issue or pull request.
163165

164166
* **Changes to the governance model** follow the process outlined in `SLEP020
165167
<https://scikit-learn-enhancement-proposals.readthedocs.io/en/latest/slep020/proposal.html>`__.

0 commit comments

Comments
 (0)
0