8000 Move pytest dependency check outside of flake8 build · scikit-learn/scikit-learn@613ebf5 · GitHub
[go: up one dir, main page]

Skip to content

Commit 613ebf5

Browse files
committed
Move pytest dependency check outside of flake8 build
with an attempt to make codecov happy
1 parent beba608 commit 613ebf5

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ matrix:
4242
- env: DISTRIB="conda" PYTHON_VERSION="3.6.2" INSTALL_MKL="true"
4343
NUMPY_VERSION="1.13.1" SCIPY_VERSION="0.19.1" PANDAS_VERSION="0.20.3"
4444
CYTHON_VERSION="0.26.1" COVERAGE=true
45+
CHECK_PYTEST_SOFT_DEPENDENCY="true"
4546
if: type != cron
4647
# flake8 linting on diff wrt common ancestor with upstream/master
47-
# and check soft dependency on pytest
48-
- env: RUN_FLAKE8="true" CHECK_PYTEST_SOFT_DEPENDENCY="true"
48+
- env: RUN_FLAKE8="true"
4949
SKIP_TESTS="true" DISTRIB="conda" PYTHON_VERSION="3.5"
5050
INSTALL_MKL="true" NUMPY_VERSION="1.13.1" SCIPY_VERSION="0.19.1"
5151
CYTHON_VERSION="0.26.1"

build_tools/travis/test_script.sh

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,5 +63,10 @@ fi
6363
if [[ "$CHECK_PYTEST_SOFT_DEPENDENCY" == "true" ]]; then
6464
conda remove -y py pytest || echo "pytest not found by conda"
6565
pip uninstall -y py pytest || echo "pytest not found by pip"
66-
PYTHONPATH=. python sklearn/utils/tests/test_estimator_checks.py
66+
if [[ "$COVERAGE" == "true" ]]; then
67+
CMD="coverage run -a"
68+
else
69+
CMD="python"
70+
fi
71+
$CMD sklearn/utils/tests/test_estimator_checks.py
6772
fi

0 commit comments

Comments
 (0)
0