Add whats new and update parameter validation

betatim · betatim · commit 44e1d8b5c70c · 2022-09-14T09:45:48.000+02:00
diff --git a/doc/whats_new/v1.2.rst b/doc/whats_new/v1.2.rst
@@ -280,6 +280,12 @@ Changelog
   in :class:`linear_model.LogisticRegression`, and will be removed in version 1.4.
   Use `None` instead. :pr:`23877` by :user:`Zhehao Liu <MaxwellLZH>`.
 
+- |Fix| :class:`linear_model.SGDOneClassSVM` no longer performs parameter
+  validation in the constructor. All validation is now handled in `fit()` and
+  `partial_fit()`.
+  :pr:`24433` by :user:`Yogendrasingh <iofall>`, :user:`Arisa Y. <arisayosh>`
+  and :user:`Tim Head <betatim>`.
+
 :mod:`sklearn.manifold`
 .......................
 
diff --git a/sklearn/linear_model/_stochastic_gradient.py b/sklearn/linear_model/_stochastic_gradient.py
@@ -2160,13 +2160,10 @@ def __init__(
         warm_start=False,
         average=False,
     ):
-
-        alpha = None
         self.nu = nu
         super(SGDOneClassSVM, self).__init__(
             loss="hinge",
             penalty="l2",
-            alpha=alpha,
             C=1.0,
             l1_ratio=0,
             fit_intercept=fit_intercept,
@@ -2360,13 +2357,11 @@ def partial_fit(self, X, y=None, sample_weight=None):
         self : object
             Returns a fitted instance of self.
         """
+        self._validate_params()
         if not hasattr(self, "coef_"):
-            self._validate_params()
             self._more_validate_params(for_partial_fit=True)
 
-        self._validate_params(for_partial_fit=True)
         alpha = self.nu / 2
-
         return self._partial_fit(
             X,
             alpha,
@@ -2463,7 +2458,6 @@ def fit(self, X, y=None, coef_init=None, offset_init=None, sample_weight=None):
         self._validate_params()
         self._more_validate_params()
 
-        self._validate_params()
         alpha = self.nu / 2
         self._fit(
             X,
