MAINT postpone erroring in 1.9 when dealing with integer in PDP (#30432)

glemaitre · web-flow · commit 3b75eb94e7d6 · 2024-12-11T15:36:54.000+01:00
diff --git a/sklearn/inspection/_partial_dependence.py b/sklearn/inspection/_partial_dependence.py
@@ -705,14 +705,14 @@ def partial_dependence(
             continue
 
         if _safe_indexing(X, feature_idx, axis=1).dtype.kind in "iu":
-            # TODO(1.8): raise a ValueError instead.
+            # TODO(1.9): raise a ValueError instead.
             warnings.warn(
                 f"The column {feature!r} contains integer data. Partial "
                 "dependence plots are not supported for integer data: this "
                 "can lead to implicit rounding with NumPy arrays or even errors "
                 "with newer pandas versions. Please convert numerical features"
                 "to floating point dtypes ahead of time to avoid problems. "
-                "This will raise ValueError in scikit-learn 1.8.",
+                "This will raise ValueError in scikit-learn 1.9.",
                 FutureWarning,
             )
             # Do not warn again for other features to avoid spamming the caller.
