8000 MAINT Parameters validation for sklearn.datasets.get_data_home (#26260) · scikit-learn/scikit-learn@363c633 · GitHub
[go: up one dir, main page]
Skip to content

Commit 363c633

Browse files
jiawei-zhang-ajeremiedbb
jiawei-zhang-a
and
jeremiedbb
authored
MAINT Parameters validation for sklearn.datasets.get_data_home (#26260)
Co-authored-by: Jérémie du Boisberranger <34657725+jeremiedbb@users.noreply.github.com>
1 parent bc3a19d commit 363c633

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

‎sklearn/datasets/_base.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@
3535
RemoteFileMetadata = namedtuple("RemoteFileMetadata", ["filename", "url", "checksum"])
3636

3737

38+
@validate_params(
39+
{
8000
40+
"data_home": [str, os.PathLike, None],
41+
}
42+
)
3843
def get_data_home(data_home=None) -> str:
3944
"""Return the path of the scikit-learn data directory.
4045
@@ -58,7 +63,7 @@ def get_data_home(data_home=None) -> str:
5863
5964
Returns
6065
-------
61-
data_home: str
66+
data_home: str or path-like, default=None
6267
The path to scikit-learn data directory.
6368
"""
6469
if data_home is None:

‎sklearn/datasets/_openml.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -903,7 +903,7 @@ def fetch_openml(
903903
data_home = None
904904
else:
905905
data_home = get_data_home(data_home=data_home)
906-
data_home = join(data_home, "openml")
906+
data_home = join(str(data_home), "openml")
907907

908908
# check valid function arguments. data_id XOR (name, version) should be
909909
# provided

‎sklearn/tests/test_public_functions.py‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -131,6 +131,7 @@ def _check_function_param_validation(
131131
"sklearn.datasets.fetch_olivetti_faces",
132132
"sklearn.datasets.fetch_rcv1",
133133
"sklearn.datasets.fetch_species_distributions",
134+
"sklearn.datasets.get_data_home",
134135
"sklearn.datasets.load_breast_cancer",
135136
"sklearn.datasets.load_diabetes",
136137
"sklearn.datasets.load_digits",

0 commit comments

Comments
 (0)
0