MAINT Parameter validation for roc_auc_score (#26007)

ansamz · jeremiedbb · web-flow · commit 310c70782bcf · 2023-04-04T13:06:21.000Z
Co-authored-by: jeremiedbb &lt;jeremiedbb@yahoo.fr&gt;
diff --git a/sklearn/metrics/_ranking.py b/sklearn/metrics/_ranking.py
@@ -378,6 +378,17 @@ def _binary_roc_auc_score(y_true, y_score, sample_weight=None, max_fpr=None):
     return 0.5 * (1 + (partial_auc - min_area) / (max_area - min_area))
 
 
+@validate_params(
+    {
+        "y_true": ["array-like"],
+        "y_score": ["array-like"],
+        "average": [StrOptions({"micro", "macro", "samples", "weighted"}), None],
+        "sample_weight": ["array-like", None],
+        "max_fpr": [Interval(Real, 0.0, 1, closed="right"), None],
+        "multi_class": [StrOptions({"raise", "ovr", "ovo"})],
+        "labels": ["array-like", None],
+    }
+)
 def roc_auc_score(
     y_true,
     y_score,
diff --git a/sklearn/metrics/tests/test_ranking.py b/sklearn/metrics/tests/test_ranking.py
@@ -778,13 +778,6 @@ def test_roc_auc_score_multiclass_labels_error(msg, y_true, labels, multi_class)
             ),
             {"multi_class": "ovo", "max_fpr": 0.5},
         ),
-        (
-            (
-                r"multi_class='ovp' is not supported for multiclass ROC AUC, "
-                r"multi_class must be in \('ovo', 'ovr'\)"
-            ),
-            {"multi_class": "ovp"},
-        ),
         (r"multi_class must be in \('ovo', 'ovr'\)", {}),
     ],
 )
diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -219,6 +219,7 @@ def _check_function_param_validation(
     "sklearn.metrics.precision_score",
     "sklearn.metrics.r2_score",
     "sklearn.metrics.recall_score",
+    "sklearn.metrics.roc_auc_score",
     "sklearn.metrics.roc_curve",
     "sklearn.metrics.top_k_accuracy_score",
     "sklearn.metrics.zero_one_loss",
