8000 MNT bare asserts (#12571) · scikit-learn/scikit-learn@1f2dd75 · GitHub
[go: up one dir, main page]

Skip to content

Commit 1f2dd75

Browse files
Ramil Nugmanovjnothman
authored andcommitted
MNT bare asserts (#12571)
1 parent 2afee93 commit 1f2dd75

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

sklearn/ensemble/tests/test_voting_classifier.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from sklearn.utils.testing import assert_almost_equal, assert_array_equal
77
from sklearn.utils.testing import assert_array_almost_equal
8-
from sklearn.utils.testing import assert_equal, assert_true, assert_false
8+
from sklearn.utils.testing import assert_equal
99
from sklearn.utils.testing import assert_raise_message
1010
from sklearn.exceptions import NotFittedError
1111
from sklearn.linear_model import LogisticRegression
@@ -337,7 +337,7 @@ def test_set_params():
337337
eclf2 = VotingClassifier([('lr', clf1), ('nb', clf3)], voting='soft',
338338
weights=[1, 2])
339339
eclf2.set_params(nb=clf2).fit(X, y)
340-
assert_false(hasattr(eclf2, 'nb'))
340+
assert not hasattr(eclf2, 'nb')
341341

342342
assert_array_equal(eclf1.predict(X), eclf2.predict(X))
343343
assert_array_almost_equal(eclf1.predict_proba(X), eclf2.predict_proba(X))
@@ -374,8 +374,8 @@ def test_set_estimator_none():
374374

375375
assert dict(eclf2.estimators)["rf"] is None
376376
assert len(eclf2.estimators_) == 2
377-
assert_true(all([not isinstance(est, RandomForestClassifier) for est in
378-
eclf2.estimators_]))
377+
assert all(isinstance(est, (LogisticRegression, GaussianNB))
378+
for est in eclf2.estimators_)
379379
assert eclf2.get_params()["rf"] is None
380380

381381
eclf1.set_params(voting='soft').fit(X, y)

0 commit comments

Comments
 (0)
0