8000 [MRG] MNT Updates pypy to use 7.2.0 (#15954) · scikit-learn/scikit-learn@1e166f7 · GitHub
[go: up one dir, main page]

Skip to content

Commit 1e166f7

Browse files
thomasjpfanrth
authored andcommitted
[MRG] MNT Updates pypy to use 7.2.0 (#15954)
1 parent 14bf5bc commit 1e166f7

File tree

4 files changed

+12
-10
lines changed

4 files changed

+12
-10
lines changed

.circleci/config.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ jobs:
101101

102102
pypy3:
103103
docker:
104-
- image: pypy:3.6-7.1.1
104+
- image: pypy:3.6-7.2.0
105105
steps:
106106
- restore_cache:
107107
keys:

build_tools/circle/build_test_pypy.sh

+8-5
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,14 @@ source pypy-env/bin/activate
1818
python --version
1919
which python
2020

21-
# XXX: numpy version pinning can be reverted once PyPy
22-
# compatibility is resolved for numpy v1.6.x. For instance,
23-
# when PyPy3 >6.0 is released (see numpy/numpy#12740)
24-
pip install --extra-index https://antocuni.github.io/pypy-wheels/ubuntu numpy Cython pytest
25-
pip install scipy sphinx numpydoc docutils joblib pillow
21+
pip install -U pip
22+
23+
# pins versions to install wheel from https://antocuni.github.io/pypy-wheels/manylinux2010
24+
pip install --extra-index-url https://antocuni.github.io/pypy-wheels/manylinux2010 numpy==1.18.0 scipy==1.3.2
25+
26+
# Install Cython directly
27+
pip install https://antocuni.github.io/pypy-wheels/ubuntu/Cython/Cython-0.29.14-py3-none-any.whl
28+
pip install sphinx numpydoc docutils joblib pillow pytest
2629

2730
ccache -M 512M
2831
export CCACHE_COMPRESS=1

conftest.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ def pytest_collection_modifyitems(config, items):
3737
skip_marker = pytest.mark.skip(
3838
reason='FeatureHasher is not compatible with PyPy')
3939
for item in items:
40-
if item.name.endswith(('hashing.FeatureHasher',
40+
if item.name.endswith(('_hash.FeatureHasher',
4141
'text.HashingVectorizer')):
4242
item.add_marker(skip_marker)
4343

sklearn/exceptions.py

+2-3
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,8 @@ class FitFailedWarning(RuntimeWarning):
139139
... print(repr(w[-1].message))
140140
FitFailedWarning('Estimator fit failed. The score on this train-test
141141
partition for these parameters will be set to 0.000000.
142-
Details:
143-
\\nTraceback (most recent call last):...\\nValueError:
144-
Penalty term must be positive; got (C=-2)\\n')
142+
Details:...Traceback (most recent call last):...ValueError:
143+
Penalty term must be positive; got (C=-2)...
145144
146145
147146
.. versionchanged:: 0.18

0 commit comments

Comments
 (0)
0