CLN fix dtype and tests

lorentzenchr · lorentzenchr · commit 1d13089c08fd · 2023-01-25T18:01:02.000+01:00
- keep dtype float32 after LSMR
- lower test precision in
 test_NewtonLSMRSolver_multinomial_A_b_on_3_classes
diff --git a/sklearn/linear_model/_glm/_newton_solver.py b/sklearn/linear_model/_glm/_newton_solver.py
@@ -918,6 +918,8 @@ def inner_solve(self, X, y, sample_weight):
             conda,
             normx,
         ) = result
+        if self.coef.dtype == np.float32:
+            self.coef_newton = self.coef_newton.astype(np.float32)
         if not self.linear_loss.base_loss.is_multiclass:
             self.gradient_times_newton = self.gradient @ self.coef_newton
         else:
diff --git a/sklearn/linear_model/_glm/tests/test_glm.py b/sklearn/linear_model/_glm/tests/test_glm.py
@@ -1512,7 +1512,7 @@ def test_NewtonLSMRSolver_multinomial_A_b_on_3_classes(
             (n_classes, -1)
         )
     # sum over classes = 0
-    assert_allclose(res1.sum(axis=0), 0, atol=5e-10)
+    assert_allclose(res1.sum(axis=0), 0, atol=5e-9)
     assert_allclose((H_ext + pen_ext) @ res1.ravel(), -(G_ext + pen_ext @ coef_ext))
     assert_allclose(A.T @ A @ res1.ravel(order="C"), A.T @ b)
     res2 = lsmr(A, b, maxiter=(n_features + n_samples) * n_classes, show=True)

Original file line number	Diff line number	Diff line change
`@@ -1512,7 +1512,7 @@ def test_NewtonLSMRSolver_multinomial_A_b_on_3_classes(`
`1512`	`1512`	`(n_classes, -1)`
`1513`	`1513`	`)`
`1514`	`1514`	`# sum over classes = 0`
`1515`		`- assert_allclose(res1.sum(axis=0), 0, atol=5e-10)`
	`1515`	`+ assert_allclose(res1.sum(axis=0), 0, atol=5e-9)`
`1516`	`1516`	`assert_allclose((H_ext + pen_ext) @ res1.ravel(), -(G_ext + pen_ext @ coef_ext))`
`1517`	`1517`	`assert_allclose(A.T @ A @ res1.ravel(order="C"), A.T @ b)`
`1518`	`1518`	`res2 = lsmr(A, b, maxiter=(n_features + n_samples) * n_classes, show=True)`