MAINT Parameters validation for sklearn.calibration.calibration_curve (#26198)

ROMEEZHOU · jeremiedbb · web-flow · commit 15012376eaa3 · 2023-04-26T13:46:54.000Z
Co-authored-by: jeremie du boisberranger &lt;jeremiedbb@yahoo.fr&gt;
diff --git a/sklearn/calibration.py b/sklearn/calibration.py
@@ -7,7 +7,7 @@
 #
 # License: BSD 3 clause
 
-from numbers import Integral
+from numbers import Integral, Real
 import warnings
 from inspect import signature
 from functools import partial
@@ -35,7 +35,13 @@
 
 from .utils.multiclass import check_classification_targets
 from .utils.parallel import delayed, Parallel
-from .utils._param_validation import StrOptions, HasMethods, Hidden
+from .utils._param_validation import (
+    StrOptions,
+    HasMethods,
+    Hidden,
+    validate_params,
+    Interval,
+)
 from .utils._plotting import _BinaryClassifierCurveDisplayMixin
 from .utils.validation import (
     _check_fit_params,
@@ -903,6 +909,15 @@ def predict(self, T):
         return expit(-(self.a_ * T + self.b_))
 
 
+@validate_params(
+    {
+        "y_true": ["array-like"],
+        "y_prob": ["array-like"],
+        "pos_label": [Real, str, "boolean", None],
+        "n_bins": [Interval(Integral, 1, None, closed="left")],
+        "strategy": [StrOptions({"uniform", "quantile"})],
+    }
+)
 def calibration_curve(
     y_true,
     y_prob,
diff --git a/sklearn/tests/test_public_functions.py b/sklearn/tests/test_public_functions.py
@@ -110,6 +110,7 @@ def _check_function_param_validation(
 
 
 PARAM_VALIDATION_FUNCTION_LIST = [
+    "sklearn.calibration.calibration_curve",
     "sklearn.cluster.cluster_optics_dbscan",
     "sklearn.cluster.compute_optics_graph",
     "sklearn.cluster.estimate_bandwidth",
