Fixup conda development installation instructions #7483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe that these two minor fixes should be worth our effort in order to maintain compatibility with conda. The first seems to be a quirk of pip and pypi which alias underscores and dashes. This isn't true in conda(-forge) which requires two separate packages. The second one line change simply updates the command to use conda-forge for all build packages since they are now available there.
|
@hmaarrfk can we update the lazy-loader package in conda-forge? |
yes. |
lagru
approved these changes
Aug 3, 2024
There was a problem hiding this comment.
Looks good, thanks @hmaarrfk! Should we wait for conda-forge/lazy_loader-feedstock#11 until we merge this?
|
Let’s reduce own own maintenance burden. Merging this immediately does not hurt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that these two minor fixes should be worth our effort in order to maintain compatibility with conda.
The first seems to be a quirk of pip and pypi which alias underscores and dashes. This isn't true in conda(-forge) which requires two separate packages. We are attempting to address this at the conda-forge level: conda-forge/lazy_loader-feedstock#11
The second one line change simply updates the command to use conda-forge for all build packages since they are now available there.
xref: https://github.com/scikit-image/scikit-image/pull/7373/files
Release note
For maintainers and optionally contributors, please refer to the instructions on how to document this PR for the release notes.