10000 JupyterLite docs link is not tied to docs version of skimage · Issue #6958 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

JupyterLite docs link is not tied to docs version of skimage #6958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
stefanv opened this issue May 25, 2023 · 3 comments · May be fixed by #7644
Open

JupyterLite docs link is not tied to docs version of skimage #6958

stefanv opened this issue May 25, 2023 · 3 comments · May be fixed by #7644
Labels
🐛 Bug

Comments

@stefanv
Copy link
Member
stefanv commented May 25, 2023 •
edited
Loading

Currently, when opening any gallery example in JupyterLite, it loads with a different version of skimage than the one used in the docs. This means that some examples won't run. The problem will get worse in the future, as APIs change.

We can now build web assembly / pyodide wheels for skimage, so the most obvious solution is to ship an skimage pyodide wheel along with the static docs deployment.

@lesteve has outlined some of these issues in #6911 (comment). They also have a working pyodide build in pyodide/pyodide#3874
@stefanv stefanv added this to the 0.21 milestone May 25, 2023
@lesteve
Copy link
Contributor
lesteve commented May 26, 2023

FYI there is also some work in progress on adding Pyodide wheels to cibuildwheel: pypa/cibuildwheel#1456

@henryiii
Copy link

FYI, building the wheel is really quite easy in GHA. See

And for an example using a pure python:

And one doing binary + docs (which I forgot about a moment ago):

@lesteve
Copy link
Contributor
lesteve commented May 29, 2023 •
edited
Loading

The thing is I don't think there is a way to do out-of-tree Pyodide builds (i.e. use pyodide build) with meson right now, at least I did not manage to do it but maybe I missed something.

Suggestions more than welcome!

@jarrodmillman jarrodmillman mentioned this issue May 31, 2023
Merged
@jarrodmillman jarrodmillman removed this from the 0.21 milestone May 31, 2023
@jarrodmillman jarrodmillman mentioned this issue May 31, 2023
Closed
@lagru lagru added the 🐛 Bug label Sep 16, 2023
@agriyakhetarpal agriyakhetarpal linked a pull request Dec 24, 2024 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
5 participants
@stefanv @jarrodmillman @lesteve @henryiii @lagru
0