8000 OpenMP build not supported for MSVC · Issue #4911 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

OpenMP build not supported for MSVC #4911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
FirefoxMetzger opened this issue Aug 12, 2020 · 2 comments
Closed

OpenMP build not supported for MSVC #4911

FirefoxMetzger opened this issue Aug 12, 2020 · 2 comments
Labels
💻 Arch specific Specific to a CPU architecture or OS

Comments

@FirefoxMetzger
Copy link
Contributor

Description

While working on #4851 I noticed that I got compiler warnings about the flag -fopenmp being unknown and, accordingly, didn't have openMP working. I'm compiling with msvc, so in my case, the flag should be /openmp.

I've updated the setup.py to assign the correct flag if the compiler is msvc:
https://gist.github.com/FirefoxMetzger/b10a215204732ebf0a2cc34b15b89039
(in particular line 99ff.)

This works in my case, but I didn't think about it too deeply. If there is interest to incorporate this change, I'll open a PR.

Way to reproduce

python setup.py build_ext

Somewhere in the build logs:

cl : Command line warning D9002 : ignoring unknown option '-fopenmp'

Version information

>>> import sys; print(sys.version)
3.7.0 (v3.7.0:1bf9cc5093, Jun 27 2018, 04:59:51) [MSC v.1914 64 bit (AMD64)]
>>> import platform; print(platform.platform())
Windows-10-10.0.17134-SP0
>>> import skimage; print("scikit-image version: {}".format(skimage.__version__))
scikit-image version: 0.18.dev0
>>> import numpy; print("numpy version: {}".format(numpy.__version__))
numpy version: 1.19.1
@emmanuelle
Copy link
Member

Thanks @FirefoxMetzger ! A PR solving this would definitely be welcome!

@FirefoxMetzger FirefoxMetzger mentioned this issue Aug 17, 2020
Merged
@emmanuelle emmanuelle mentioned this issue Aug 17, 2020
Closed
@rfezzani rfezzani added the 💻 Arch specific Specific to a CPU architecture or OS label Oct 18, 2021
@rfezzani
Copy link
Member

Closed by #4924

@grlee77 grlee77 mentioned this issue Feb 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 Arch specific Specific to a CPU architecture or OS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@emmanuelle @rfezzani @FirefoxMetzger
0