10000 flood_fill and flood are both in segmentation and morphology · Issue #4618 · scikit-image/scikit-image · GitHub
[go: up one dir, main page]
Skip to content

flood_fill and flood are both in segmentation and morphology #4618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emmanuelle opened this issue Apr 26, 2020 · 3 comments
Open

flood_fill and flood are both in segmentation and morphology #4618

emmanuelle opened this issue Apr 26, 2020 · 3 comments
Labels
📜 type: API Involves API change(s) 💬 Discussion

Comments

@emmanuelle
Copy link
Member

The functions flood_fill and flood are both in the segmentation and in the morphology submodules, and neither is deprecated. I don't think we should keep the two versions in the API, but that we should deprecate one of them (probably keep segmentation?).

@JDWarner
@emmanuelle emmanuelle mentioned this issue Apr 26, 2020
Merged
@rfezzani
Copy link
Member

This reminds me this discussion #4400 (comment) ;-)

@sciunto sciunto mentioned this issue Apr 27, 2020
Closed
@soupault
Copy link
Member

I remember these two original arguments by @JDWarner - #3245 (comment), #3245 (comment). To me, both of them still sound reasonable.

@jni
Copy link
Member
jni commented Apr 29, 2020

Yeah, this is the recurring problem of tags vs folders. For a while, we decided to treat our modules as tags (watershed was also in both morphology and segmentation), as a solution to the problem that even advanced users such as myself were unable to find said watershed (after my proposal of a flat namespace was rejected. ;)

I think our latest consensus is that we want our modules to reflect purpose rather than the discipline from which they stem. So I think flood should probably go in segmentation, if we pick one.

@scikit-image scikit-image locked and limited conversation to collaborators Oct 18, 2021
@grlee77 grlee77 mentioned this issue Feb 20, 2022
Closed
@scikit-image scikit-image unlocked this conversation Mar 2, 2022
@grlee77 grlee77 reopened this Mar 2, 2022
@grlee77 grlee77 added the 📜 type: API Involves API change(s) label Mar 2, 2022
4C3C Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📜 type: API Involves API change(s) 💬 Discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@emmanuelle @jni @soupault @rfezzani @grlee77
0