Refactoring: Isolate handling of javalib methods with special bodies.#5173
Merged
sjrd merged 1 commit intoscala-js:mainfrom May 19, 2025
Merged
Conversation
A number of methods from the javalib are special-cased by the compiler, which replaces their body with a dedicated `UnaryOp` or `BinaryOp`. This commit refactors that handling to isolate it better from the handling of regular methods. We also make it a bit more flexible, so that we can more easily add further such methods in the future.
gzm0
approved these changes
May 19, 2025
Contributor
There was a problem hiding this comment.
LGTM. I agree that using an abstract method does not improve readability, but IMO it keeps related logic closer together. So I would stick with it.
Member
Author
|
OK, let's stick with it, then. I have no strong feeling either way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of methods from the javalib are special-cased by the compiler, which replaces their body with a dedicated
UnaryOporBinaryOp.This commit refactors that handling to isolate it better from the handling of regular methods. We also make it a bit more flexible, so that we can more easily add further such methods in the future.
Extracted from several ongoing PRs. Comments from #5158:
46962c5#r2094545568
Mostly for convenience. I added a comment on the definition of
JavalibMethodsWithOpBody.46962c5#r2094546049
I switched to an abstract method, but I'm not sure it's more readable.