Support java.io.BufferedWriter #5014
Labels
missing javalib
Report of something from the JDK that is missing (does not link)
Comments
|
Typically, Scala.js has stricter code quality and testing requirements than Native. But maybe it's easiest if you open a PR and in the review process we address these? It's not like the API is so huge. |
ThijsBroersen
added a commit
to ThijsBroersen/scala-js
that referenced
this issue
Aug 16, 2024
Implementation copied from Scala-native
|
Created a PR: #5015 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While trying to cross-compile some zio-json code for supporting streaming json-lines, I ran into the issue that
java.io.BufferedWriterwas not implemented in Scala-js.I was also cross-compiling to Scala-native and there the BufferedWriter class is implemented. I tried to use the same implementation for Scala-js and it turns out it just works out of the box. This is the implementation: https://github.com/scala-native/scala-native/blob/d5d65e755a4fb40a1c562d50b046384000232b23/javalib/src/main/scala/java/io/BufferedWriter.scala#L4
Can this be included in Scala-js?
I could make a PR with this single file and include e.g. this test: https://github.com/scala-native/scala-native/blob/d5d65e755a4fb40a1c562d50b046384000232b23/unit-tests/shared/src/test/scala/org/scalanative/testsuite/javalib/io/BufferedWriterTest.scala#L10
Anything else?
The text was updated successfully, but these errors were encountered: