Squash: Make PrimRef not even a case class anymore.

sjrd · sjrd · commit d6f672500cbb · 2025-03-14T20:54:07.000+01:00
diff --git a/ir/shared/src/main/scala/org/scalajs/ir/Types.scala b/ir/shared/src/main/scala/org/scalajs/ir/Types.scala
@@ -258,7 +258,7 @@ object Types {
   sealed abstract class NonArrayTypeRef extends TypeRef
 
   /** Primitive type reference. */
-  final case class PrimRef private[Types] (tpe: PrimTypeWithRef)(
+  final class PrimRef private[Types] (val tpe: PrimTypeWithRef)(
       charCodeInit: Char, displayNameInit: String) // "Init" variants so we can have good Scaladoc on the val's
       extends NonArrayTypeRef {
 
@@ -284,16 +284,11 @@ object Types {
      *  respectively.
      */
     val charCode: Char = charCodeInit
-
-    // Make sure the `case class` does not produce a public copy method
-    private def copy(tpe: PrimTypeWithRef)(charCodeInit: Char, displayNameInit: String): PrimRef =
-      throw new Error("dead code")
   }
 
   object PrimRef {
-    // Make sure the `case class` does not produce a public apply method
-    private def apply(tpe: PrimTypeWithRef)(charCodeInit: Char, displayNameInit: String): PrimRef =
-      throw new Error("dead code")
+    def unapply(typeRef: PrimRef): Some[PrimTypeWithRef] =
+      Some(typeRef.tpe)
   }
 
   final val VoidRef = VoidType.primRef
diff --git a/project/BinaryIncompatibilities.scala b/project/BinaryIncompatibilities.scala
@@ -16,6 +16,15 @@ object BinaryIncompatibilities {
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types.BoxedClassToPrimType"),
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types.PrimTypeToBoxedClass"),
 
+    // !!! Breaking, PrimRef is not a case class anymore
+    ProblemFilters.exclude[MissingTypesProblem]("org.scalajs.ir.Types$PrimRef"),
+    ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.canEqual"),
+    ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.productArity"),
+    ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.productElement"),
+    ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.productIterator"),
+    ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.productPrefix"),
+    ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.scalajs.ir.Types#PrimRef.unapply"),
+
     // !!! Breaking I guess ... we used to leak public things out of a `case class` with a private[ir] constructor
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.this"),
     ProblemFilters.exclude[DirectMissingMethodProblem]("org.scalajs.ir.Types#PrimRef.apply"),
