8000 Address two minor comments. · scala-js/scala-js@b361a1d · GitHub
[go: up one dir, main page]

Skip to content

Commit b361a1d

Browse files
committed
Address two minor comments.
1 parent 397acd1 commit b361a1d
< 8000 /header>

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

ir/shared/src/main/scala/org/scalajs/ir/Printers.scala

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -378,15 +378,7 @@ object Printers {
378378

379379
print("def ")
380380
print(methodName)
381-
print('(')
382-
if (paramTypes.nonEmpty) {
383-
print(paramTypes.head)
384-
for (tpe <- paramTypes.tail) {
385-
print(", ")
386-
print(tpe)
387-
}
388-
}
389-
print("): ")
381+
printRow(paramTypes, "(", ", ", "): ")
390382
print(resultType)
391383
print(',')
392384
println()

linker/shared/src/main/scala/org/scalajs/linker/checker/FeatureSet.scala

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,14 @@ private[checker] object FeatureSet {
7171

7272
// Common sets
7373

74-
/** Features introduced by the base linker. */
74+
/** Features introduced by the base linker.
75+
*
76+
* Although `NewLambda` nodes themselves are desugared in the `Desugarer`,
77+
* the corresponding synthetic *classes* already have an existence after the
78+
* `BasedLinker`. They must, since they must participate in the CHA
79+
* performed by the `Analyzer`. So `TransientTypeRef`s and `TypedClosure`s
80+
* can already appear after the `BaseLinker`.
81+
*/
7582
private val Linked =
7683
OptionalConstructors | ReflectiveProxies | TransientTypeRefs | TypedClosures
7784

0 commit comments

Comments
 (0)
0