8000 Akka test failures in community build (expired certificate) · Issue #904 · scala/scala-dev · GitHub
[go: up one dir, main page]
Skip to content

Akka test failures in community build (expired certificate) #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lrytz opened this issue Apr 25, 2025 · 7 comments
Closed

Akka test failures in community build (expired certificate) #904

lrytz opened this issue Apr 25, 2025 · 7 comments 8000

Comments

@lrytz
Copy link
Member
lrytz commented Apr 25, 2025

https://scala-ci.typesafe.com/job/scala-2.13.x-jdk17-integrate-community-build/2626/artifact/logs/akka-http-build.log

Various tests fail with SSLHandshakeException: NotAfter: Mon Apr 21 09:51:22 UTC 2025.

Something expired.
@lrytz
Copy link
Member Author
lrytz commented Apr 25, 2025

probably akka/akka-http#4483, @johanandren?

@lrytz
Copy link
Member Author
lrytz commented Apr 25, 2025

@SethTisue I'm confused... in https://github.com/scala/community-build/blob/2.13.x/proj/akka-http.conf i see

uri: "https://github.com/akka/akka-http.git#b1f3d52c4c3be8b0baf795d6c6d742b862628367"

but I cannot find that revision on akka/akka-http@b1f3d52.

In the build logs I see Commit: 27598478891acc679c82654f1b0b7dbc6dc04647, no idea where that comes from.

[akka-http] --== Extracting dependencies for akka-http ==--
[akka-http] Fetching https://github.com/akka/akka-http.git
[akka-http] into /home/jenkins/workspace/scala-2.13.x-jdk17-integrate-community-build/clones-0.9.20/fa9fb0dd60d38cdf83ecf2e72dd876a7c9dcd89a-akka-http
[akka-http] Took: 00h 00m 03.5s
[akka-http] Fetching /home/jenkins/workspace/scala-2.13.x-jdk17-integrate-community-build/clones-0.9.20/fa9fb0dd60d38cdf83ecf2e72dd876a7c9dcd89a-akka-http
[akka-http] into /home/jenkins/workspace/scala-2.13.x-jdk17-integrate-community-build/target-0.9.20/extraction/32c4a7e3973fa44da8b1f7e66074c242f4eb9c9b/projects/aa94fcaa1c8bc745ddd926cabeb501741b035eeb
[akka-http] Took: 00h 00m 03.2s
[akka-http] Commit: 27598478891acc679c82654f1b0b7dbc6dc04647
[akka-http] The following subprojects will be built in project akka-http: akka-parsing, akka-http-scalafix-rules, akka-http-core, akka-http, akka-http-testkit, akka-http-caching, akka-http-jackson, akka-http-marshallers-java, akka-http-spray-json, akka-http-xml, akka-http-marshallers-scala, akka-http-scalafix-test-input, akka-http-scalafix-test-output, akka-http2-support, akka-http-tests, akka-http-scalafix, bill-of-materials, akka-http-compatibility-tests, akka-http-root
[akka-http] --== End Extracting dependencies for akka-http ==--

@johanandren
Copy link

Yep, probably, we've had two sets of test certs run out of their best-before, the one you linked was the most recent, and akka/akka-http#4475 roughly a month ago

@SethTisue
Copy link
Member
SethTisue commented May 4, 2025 •
edited
Loading

I cannot find that revision on akka/akka-http@b1f3d52

that's the tag commit. it surprises me that GitHub won't show it (TIL!), but if we clone the repo:

% git show --stat b1f3d52c4c3be8b0baf795d6c6d742b862628367
tag v10.2.10
Tagger: Johan Andrén <johan@markatta.com>
Date:   Tue Sep 6 14:02:44 2022 +0200

Release 10.2.10

commit 27598478891acc679c82654f1b0b7dbc6dc04647 (tag: v10.2.10, origin/release-10.2)
Author: Johan Andrén <johan@markatta.com>
Date:   Tue Sep 6 13:03:39 2022 +0200

    doc: Release notes for 10.2.10 (#4154)

 docs/src/main/paradox/release-notes/10.2.x.md | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

so you can equally well use akka/akka-http@2759847, it's a distinction without a difference

the usual thing to do in this situation is to cherry-pick the needed changes into https://github.com/scalacommunitybuild/akka-http/tree/community-build-2.13

note that there is an existing community-build-2.13 branch but it's not referenced from proj/akka-http.conf. that means the branch is old and stale and it's fine to simply force-push and overwrite it. one could imagine have a whole series of such branches instead of reusing the same branch, but I've always shrugged and reused the same branch, and doing so has never bitten me

@lrytz
Copy link
Member Author
lrytz commented May 5, 2025

Thanks! I didn't see that the .conf file have a reference to the origin in the first line.

@SethTisue
Copy link
Member

@lrytz yeah, that first-line comment is what the advance script uses to update the SHA

@lrytz
Copy link
Member Author
lrytz commented May 6, 2025

scala/community-build@4797ab1

cb is green https://scala-ci.typesafe.com/

@lrytz lrytz closed this as completed May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lrytz @SethTisue @johanandren
0